Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'union' and 'intersect' descriptions in gdal_calc.py documentation #5969

Closed
wants to merge 1 commit into from
Closed

Conversation

ste-goldstein
Copy link

The definitions of the union and intersect parameters of the extent option seemed to be reversed in the gdal_calc.py documentation

The definitions of the union and intersect options seemed to be reversed
@jratike80
Copy link
Collaborator

jratike80 commented Jun 23, 2022

I am not sure. If this is the situation
image
then isn't the union case this
image
but the intersect case this
image
Maybe the latter should rather be called as "intersection".

@rouault
Copy link
Member

rouault commented Jun 23, 2022

@idanmiara can you check this proposed change ? (I'm not sure it is. the current description seems consistent with the behaviour I'd expect from the naming of the options)

@ste-goldstein
Copy link
Author

The functions work as expected. And their description is also actually right.
Apologies for this. The words minimal and maximal led me to a wrong interpretation while not reading it too carefully.
Closing PR

@ste-goldstein ste-goldstein deleted the patch-1 branch June 23, 2022 10:22
@idanmiara
Copy link
Collaborator

The functions work as expected. And their description is also actually right. Apologies for this. The words minimal and maximal led me to a wrong interpretation while not reading it too carefully. Closing PR

Yes, correct. But I see your point. Do you want to rephrase the definition?

@lnicola
Copy link
Contributor

lnicola commented Oct 17, 2022

TBH, I think the current phrasing is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants