Add basic support and tests for Ubuntu 22.04 LTS #5543

mayrstefan · 2022-06-05T20:58:21Z

What does this PR change?

This is some basic preparation to support Ubuntu 22.04 LTS

GUI diff

No difference.

Documentation

Issue: https://github.com/SUSE/spacewalk/issues/18278
DONE

Test coverage

Cucumber tests were added
DONE

Links

Partially fixes #5320

DONE

Changelogs

Added
DONE

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

Re-run test "changelog_test"
Re-run test "backend_unittests_pgsql"
Re-run test "java_pgsql_tests"
Re-run test "schema_migration_test_pgsql"
Re-run test "susemanager_unittests"
Re-run test "javascript_lint"
Re-run test "spacecmd_unittests"

srbarrios

Test Framework changes looks good to me.
I can't give feedback about the rest.

srbarrios · 2022-06-08T09:43:19Z

testsuite/features/build_validation/reposync/srv_sync_all_products.feature

+    And I enter "Ubuntu 22.04" as the filtered product description
+    And I select "Ubuntu 22.04" as a product
+    Then I should see the "Ubuntu 22.04" selected
+    When I click the Add Product button


I can't confirm it, as I can't see Ubuntu 22.04 in my current environment.
But we might need to select also some child channel not selected automatically, for instance something related to LTSS.
As we do in When I select "SUSE Linux Enterprise Server LTSS 15 x86_64" as a product

I copied this from Ubuntu 20.04 as a wild guess. This seems to be the same for all Ubuntu and Debian variants. And Ubuntu 22.04 is a LTS release by definition.

juliogonzalez

This PR looks very good! :-D

Some minor changes are required.

Also, can you grant me rights at your repo, so I can build the packages and test everything during the hackweek, and do changes (if needed)?

Thanks!

juliogonzalez · 2022-06-08T09:45:09Z

susemanager-sync-data/additional_products.json

@@ -1,4 +1,191 @@
 [
+    {


Unless @mcalmer can already provide the right IDs, I'd say this needs to go away?

Please remove this file from the PR. This file is generated by an internal tool.
Maybe you can paste it as comment to the PR, so we can fetch it and compare it with what we generate.

susemanager/src/mgr_bootstrap_data.py

juliogonzalez · 2022-06-08T09:46:02Z

susemanager/src/mgr_bootstrap_data.py

@@ -1516,6 +1535,11 @@
        'DEST' : DOCUMENT_ROOT + '/pub/repositories/ubuntu/20/4/bootstrap/',
        'TYPE' : 'deb'
    },
+    'ubuntu-22.04-amd64' : {


@mcalmer I think this should go away for now, as we do not have the SCC client tools channels?

yes, especially as we do not know if -33 will be the final product id or not.

java/code/src/com/redhat/rhn/domain/server/MinionServer.java

susemanager-utils/susemanager-sls/susemanager-sls.changes

juliogonzalez · 2022-06-13T21:19:54Z

Part of Hackweek 21 at https://hackweek.opensuse.org/21/projects/testing-gnu-slash-linux-distributions-on-uyuni.

Main focus for me would be testing, as it seems most if the work is done by @mayrstefan

juliogonzalez · 2022-06-27T12:37:39Z

I am building the packages at https://build.opensuse.org/project/show/home:juliogonzalezgil:branches:systemsmanagement:Uyuni:Master, for testing

juliogonzalez

Ok, I tested this PR, and can confirm the basic stuff works, as you can see at https://hackweek.opensuse.org/21/projects/testing-gnu-slash-linux-distributions-on-uyuni

I am now adding more reviewers, and if they approve, we can merge. But to have Ubuntu 22.04 we need https://build.opensuse.org/request/show/985321 accepted, and them submitted and released to the SLE15 codestreams (so it gets into openSUSE Leap 15.4)

mayrstefan · 2022-06-30T19:16:09Z

Sounds good. What about the repository IDs? Will you replace them with the correct numbers or should we remove this block?

juliogonzalez · 2022-06-30T21:00:04Z

Sounds good. What about the repository IDs? Will you replace them with the correct numbers or should we remove this block?

We'll see, maybe @mcalmer wants to keep them and fix the IDs later. For now people will need to review, and we also need to merge my SRs for reprepro (bootstrap repository generation) and get the updated python-debian at SLE/openSUSE, as well as the documentation.

When the four things are ready, then we can officially have Ubuntu 22.04 as part of Uyuni. Hopefully for 2022.07. We'll see.

mcalmer · 2022-07-01T07:02:11Z

susemanager-sync-data/additional_products.json

@@ -1,4 +1,191 @@
 [
+    {


Please remove this file from the PR. This file is generated by an internal tool.
Maybe you can paste it as comment to the PR, so we can fetch it and compare it with what we generate.

mcalmer · 2022-07-01T07:03:16Z

susemanager/src/mgr_bootstrap_data.py

@@ -1516,6 +1535,11 @@
        'DEST' : DOCUMENT_ROOT + '/pub/repositories/ubuntu/20/4/bootstrap/',
        'TYPE' : 'deb'
    },
+    'ubuntu-22.04-amd64' : {


yes, especially as we do not know if -33 will be the final product id or not.

juliogonzalez · 2022-07-01T10:13:15Z

@mcalmer all done. For the Java part, I don't know if those changes are enough or not.

mcalmer

Looks good, but check the checkstyle error.
More product handling in the java code is only needed for RHEL like Products.

juliogonzalez · 2022-07-01T11:48:19Z

Looks good, but check the checkstyle error.
Done

More product handling in the java code is only needed for RHEL like Products.

Ok so, I guess the product detection shows "Uknown" because this product is still not defined at sumatoolbox, or SCC, or whatever else, right?

mcalmer · 2022-07-01T12:19:30Z

Ok so, I guess the product detection shows "Uknown" because this product is still not defined at sumatoolbox, or SCC, or whatever else, right?

Correct.

meaksh

LGTM, thanks

supported variant for new clients

mayrstefan requested a review from a team as a code owner June 5, 2022 20:58

github-actions bot added build-validation-features ci-pipelines data-model java java_lint_checkstyle java_pgsql_tests python3 ruby_rubocop susemanager_unittests test-framework testing labels Jun 5, 2022

srbarrios approved these changes Jun 8, 2022

View reviewed changes

srbarrios reviewed Jun 8, 2022

View reviewed changes

juliogonzalez self-requested a review June 8, 2022 09:44

juliogonzalez requested changes Jun 8, 2022

View reviewed changes

juliogonzalez requested a review from mcalmer June 8, 2022 09:49

juliogonzalez approved these changes Jun 30, 2022

View reviewed changes

juliogonzalez requested a review from meaksh June 30, 2022 09:52

mcalmer requested changes Jul 1, 2022

View reviewed changes

juliogonzalez requested a review from mcalmer July 1, 2022 10:13

mcalmer approved these changes Jul 1, 2022

View reviewed changes

juliogonzalez requested a review from a team July 4, 2022 10:20

juliogonzalez removed the request for review from meaksh July 4, 2022 10:20

meaksh approved these changes Jul 8, 2022

View reviewed changes

mayrstefan and others added 5 commits July 8, 2022 11:13

Add support and tests for Ubuntu 22.04 LTS

fd3c45d

Reduce package list to venv-salt-minion as this will be the only

d59ec1e

supported variant for new clients

Move changelog entry to correct file

2cbff08

Remove uneeded stuff

d0d3b7a

Fix a long line

ce59c0d

juliogonzalez merged commit dd4d0c0 into uyuni-project:master Jul 8, 2022

mayrstefan mentioned this pull request Jul 9, 2022

Add Ubuntu 22.04 uyuni-project/uyuni-docs#1654

Merged

4 tasks

raulillo82 mentioned this pull request Mar 12, 2024

Add basic support and tests for Ubuntu 24.04 LTS #8448

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic support and tests for Ubuntu 22.04 LTS #5543

Add basic support and tests for Ubuntu 22.04 LTS #5543

mayrstefan commented Jun 5, 2022 •

edited by juliogonzalez

srbarrios left a comment

srbarrios Jun 8, 2022

mayrstefan Jun 8, 2022

juliogonzalez left a comment

juliogonzalez Jun 8, 2022

mcalmer Jul 1, 2022

juliogonzalez Jun 8, 2022

mcalmer Jul 1, 2022

juliogonzalez commented Jun 13, 2022

juliogonzalez commented Jun 27, 2022

juliogonzalez left a comment

mayrstefan commented Jun 30, 2022

juliogonzalez commented Jun 30, 2022

mcalmer Jul 1, 2022

mcalmer Jul 1, 2022

juliogonzalez commented Jul 1, 2022

mcalmer left a comment

juliogonzalez commented Jul 1, 2022

mcalmer commented Jul 1, 2022

meaksh left a comment

Add basic support and tests for Ubuntu 22.04 LTS #5543

Add basic support and tests for Ubuntu 22.04 LTS #5543

Conversation

mayrstefan commented Jun 5, 2022 • edited by juliogonzalez

What does this PR change?

GUI diff

Documentation

Test coverage

Links

Changelogs

Re-run a test

srbarrios left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliogonzalez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliogonzalez commented Jun 13, 2022

juliogonzalez commented Jun 27, 2022

juliogonzalez left a comment

Choose a reason for hiding this comment

mayrstefan commented Jun 30, 2022

juliogonzalez commented Jun 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliogonzalez commented Jul 1, 2022

mcalmer left a comment

Choose a reason for hiding this comment

juliogonzalez commented Jul 1, 2022

mcalmer commented Jul 1, 2022

meaksh left a comment

Choose a reason for hiding this comment

mayrstefan commented Jun 5, 2022 •

edited by juliogonzalez