Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror the complete pub folder in containerized proxy #5596

Merged

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jun 23, 2022

What does this PR change?

Since the user cannot call mgr-bootstrap on the containerized proxies,
mirror the complete /pub folder to get the server SSL cert and the
/pub/bootstrap folder content. (bsc#1199802)

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: proxy containers are not yet tested automatically

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/17942

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbosdo cbosdo requested a review from aaannz June 23, 2022 08:11
@cbosdo cbosdo requested a review from a team as a code owner June 23, 2022 08:11
@aaannz
Copy link
Contributor

aaannz commented Jun 23, 2022

Don't we need to adjust squid config as well?
Is default refresh_pattern . 0 100% 525600 ok for it? I am not an expert on squid config, but this seems like a setup for stable files.

@cbosdo cbosdo changed the title Mirror the complete pub folder in containeriwed proxy Mirror the complete pub folder in containerized proxy Jun 23, 2022
@cbosdo cbosdo force-pushed the container-proxy-mirror-pub branch from 02a789b to 6a1001c Compare June 23, 2022 08:47
@cbosdo
Copy link
Contributor Author

cbosdo commented Jun 23, 2022

Don't we need to adjust squid config as well? Is default refresh_pattern . 0 100% 525600 ok for it? I am not an expert on squid config, but this seems like a setup for stable files.

oh right, we may want to tweak this... but I am not a squid user as well

@cbosdo
Copy link
Contributor Author

cbosdo commented Jul 6, 2022

Don't we need to adjust squid config as well? Is default refresh_pattern . 0 100% 525600 ok for it? I am not an expert on squid config, but this seems like a setup for stable files.

oh right, we may want to tweak this... but I am not a squid user as well

Seems to me that those files are fairly stable and not updated that often... I would consider it good enough for now and adjust later if there is any issue

Since the user cannot call mgr-bootstrap on the containerized proxies,
mirror the complete /pub folder to get the server SSL cert and the
/pub/bootstrap folder content. (bsc#1199802)
@cbosdo cbosdo force-pushed the container-proxy-mirror-pub branch from 6a1001c to 0af6cff Compare July 14, 2022 13:27
@cbosdo cbosdo added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jul 14, 2022
@juliogonzalez juliogonzalez removed the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jul 14, 2022
@juliogonzalez
Copy link
Member

Label removed. Please add it only when all conditions are met (reviewers are still pending)

@juliogonzalez juliogonzalez added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jul 14, 2022
@juliogonzalez juliogonzalez merged commit 02a4b07 into uyuni-project:master Jul 14, 2022
@cbosdo cbosdo deleted the container-proxy-mirror-pub branch July 14, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants